November 2007 Commit Log

Number of Commits:

9

Number of Active Developers:

1

norbertmocsnik 2007-11-30 21:22 #9 Rev.: 631

Simplified the (still) broken Portal example.

6 lines of code changed in 1 file:

• trunk/acceptance/template/portal: index.php (+6 -24)

norbertmocsnik 2007-11-30 21:03 #8 Rev.: 630

Fixed broken forms. When a custom run-time view is provided for a compile-time form input component, we assume that the tag name is hardcoded into it. Otherwise, the component renders the tag name into the compiled template and the default form element view is used.

3 lines of code changed in 1 file:

• trunk/wact/plugins/template/form: input.tag.php (+3 -1)

norbertmocsnik 2007-11-30 20:34 #7 Rev.: 629

Fixed Hangman example: WactPartialView::setUp() is called prior to WactPartialView::bindToAncestors() when $this->data is unavailable yet. This code needs to take place inside an onPreRenderDo event handler. It is mandatory that we clarify the view lifecycle very soon.

2 lines of code changed in 1 file:

• trunk/examples/hangman: index.php (+2 -2)

norbertmocsnik 2007-11-27 23:44 #6 Rev.: 628

Fixed failing controller test cases (again).

When searching for the direct base parameter ("parent") for any segmented parameter, traversing each controllers' parameters in reverse order assumes that the user defined the base parameter before the segmented parameter on a controller (because, if there is both a segmented and a base parameter on a controller, we need to access the segmented first).

The failing test cases and examples showed that the necessity of defining the base parameter first, the segmented parameter second is not obvious and not necessarily the case.

It is safer instead to check, on each level in the controller chain, for related segmented parameters first (their baseName equals my baseName), then for other parameters in order to find the base (their name equals my baseName).

24 lines of code changed in 1 file:

• trunk/wact/controller: request.inc.php (+24 -8)

norbertmocsnik 2007-11-27 21:47 #5 Rev.: 627

Reverted r625 and r624.

6 lines of code changed in 1 file:

• trunk/wact/controller: request.inc.php (+6 -35)

norbertmocsnik 2007-11-27 20:37 #4 Rev.: 626

Checked in a new failing controller test case.

23 lines of code changed in 1 file:

• trunk/wact/controller: pathinfo.test.php (+23)

norbertmocsnik 2007-11-27 19:31 #3 Rev.: 625

Simplified the previous fix (no need to pass the parameter name to the parameter itself).

9 lines of code changed in 1 file:

• trunk/wact/controller: request.inc.php (+9 -9)

norbertmocsnik 2007-11-27 19:09 #2 Rev.: 624

Fixed failing controller test cases by extracting out hardcoded PATH_INFO channel read from WactSegmentedParameter::WriteValueToTransition() into the the GET, POST, PATH_INFO and Segmented parameters, each reading its own channel. Currently only PATH_INFO is used.

35 lines of code changed in 1 file:

• trunk/wact/controller: request.inc.php (+35 -6)

norbertmocsnik 2007-11-27 14:23 #1 Rev.: 623

At the moment, WactSegmentedParameter requires explicit registering of its base parameter.

1 lines of code changed in 1 file:

• trunk/examples/hangman: index.php (+1)

October 2007 »